Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge query defaults #4849

Merged
merged 7 commits into from
Jan 22, 2023
Merged

feat: merge query defaults #4849

merged 7 commits into from
Jan 22, 2023

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Jan 21, 2023

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 21, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7700d03:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (v5@8c373d2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@          Coverage Diff          @@
##             v5    #4849   +/-   ##
=====================================
  Coverage      ?   90.98%           
=====================================
  Files         ?       85           
  Lines         ?     3459           
  Branches      ?      872           
=====================================
  Hits          ?     3147           
  Misses        ?      291           
  Partials      ?       21

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo marked this pull request as ready for review January 21, 2023 21:38
ecyrbe
ecyrbe reviewed Jan 21, 2023
View reviewed changes
Copy link
Contributor

@ecyrbe ecyrbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review

packages/query-core/src/queryClient.ts Outdated Show resolved Hide resolved
@TkDodo TkDodo merged commit 95ae966 into v5 Jan 22, 2023
@TkDodo TkDodo deleted the query-defaults branch January 22, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecyrbe ecyrbe ecyrbe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TkDodo @codecov-commenter @ecyrbe