-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix(core): make sure pausedMutations always execute in serial #4906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
when resumePausedMutations is called multiple times, we are starting the second paused mutation even though the first one has not yet finished. This can happen when a focus event and an online event happen in short succession
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@jligeza I've reverted, and here is the same PR again in draft version. I won't get around to taking another look soon, but maybe you want to look into or know why this happened 🤔 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 66d3a2a:
|
mutation.continue() needs to immediately resolve back if we didn't really continue so that consecutive calls to resumePausedMutations can be appended to the promise chain
Codecov ReportBase: 91.70% // Head: 91.85% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #4906 +/- ##
==========================================
+ Coverage 91.70% 91.85% +0.15%
==========================================
Files 111 111
Lines 4133 4138 +5
Branches 1064 1067 +3
==========================================
+ Hits 3790 3801 +11
+ Misses 322 316 -6
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@jligeza can you please check one more time with this sandbox: I've added some log statements and they always execute in serial now for me. For some reason, the submitted mutation doesn't show up on screen though? That's why I added the extra log statements in the mutationFn. Please confirm. |
Works for me. |
when resumePausedMutations is called multiple times, we are starting the second paused mutation even though the first one has not yet finished. This can happen when a focus event and an online event happen in short succession
closes #4896