feat(query-devtools): Add btn position relative support #6576
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cadbf10:
|
happycollision
force-pushed
the
devtools-btn-pos-relative
branch
from
6912797 to
b1ad097
Compare
|
looks good. can you please fix the conflicts? |
In addition to adding support for relative positioning of the button, I've added in opacity changes for all in/out animations.
happycollision
force-pushed
the
devtools-btn-pos-relative
branch
from
b1ad097 to
cadbf10
Compare
|
@TkDodo Just letting you know it's done. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cadbf10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6576 +/- ##
==========================================
- Coverage 41.78% 4.38% -37.41%
==========================================
Files 178 10 -168
Lines 7017 1484 -5533
Branches 1421 368 -1053
==========================================
- Hits 2932 65 -2867
+ Misses 3722 1257 -2465
+ Partials 363 162 -201 ☔ View full report in Codecov by Sentry. |
|
Thanks for working on this! Looks good |
In addition to adding support for relative positioning of the button, I've added in opacity changes for all in/out animations.
This change makes it possible to control the location of the button, in case you have other floating panels, etc., in your app.
The gif below shows a change to the playground example (not committed), that illustrates what is now possible.
My motivation was purely because I have an application with a bunch of devtools in a drawer that I move around the screen as necessary while I develop. The previous version of RQ's devtools allowed me to pass a style directly to the button to control its position so that I could contain it within the drawer. This newer version does not. But allowing the button to just be positioned relatively works just fine for that purpose.
You can see below (in the lower right of each image) the best I could do to get v5 to play ball, compared to v4. (And forget moving the panel around!)