Skip to content

Conversation

manudeli
Copy link
Collaborator

@manudeli manudeli commented Jan 11, 2024

fix below

image

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 10:57am

Copy link

nx-cloud bot commented Jan 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b4323f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Jan 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b4323f:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli force-pushed the chore/tsconfig-correctly-to-be-affected-by-eslint branch from dc2b983 to fbc5248 Compare January 11, 2024 19:33
@manudeli manudeli marked this pull request as ready for review January 11, 2024 19:36
@manudeli manudeli changed the title chore: include field of tsconfig correctly to be affected by @typescript chore: include field of tsconfig correctly to be affected by eslint with typescript Jan 11, 2024
@lachlancollins lachlancollins changed the title chore: include field of tsconfig correctly to be affected by eslint with typescript chore: Fix eslint errors when parsing tsconfig.json files Jan 13, 2024
Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manudeli !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c697605) 41.71% compared to head (1b4323f) 5.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #6688       +/-   ##
==========================================
- Coverage   41.71%   5.04%   -36.67%     
==========================================
  Files         179      62      -117     
  Lines        7007    2317     -4690     
  Branches     1416     196     -1220     
==========================================
- Hits         2923     117     -2806     
+ Misses       3713    2082     -1631     
+ Partials      371     118      -253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 3a127bf into TanStack:main Jan 13, 2024
@lachlancollins lachlancollins changed the title chore: Fix eslint errors when parsing tsconfig.json files chore: Fix eslint errors when parsing vite config files Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants