Skip to content

Conversation

YanZisuka
Copy link
Contributor

isLoading (isPending && isFetching) is a value calculated from isPending.

Therefore, if isPending is false, isLoading becomes false, and if isLoading is true, isPending also becomes true, so modify the related type.

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 1:53pm

Copy link

codesandbox-ci bot commented Jan 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 584cf24:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes are correct. Could you please add some type-tests to verify ?

@YanZisuka YanZisuka force-pushed the fix/type-query-observer-result branch from cc7181e to 584cf24 Compare January 16, 2024 13:53
@YanZisuka
Copy link
Contributor Author

@TkDodo

Thank you for your quick response!

Type testing is a bit new, but I've added some cases. Thanks for the review.

@YanZisuka YanZisuka requested a review from TkDodo January 16, 2024 13:54
Copy link

nx-cloud bot commented Jan 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 584cf24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a127bf) 41.71% compared to head (584cf24) 58.64%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6716       +/-   ##
===========================================
+ Coverage   41.71%   58.64%   +16.92%     
===========================================
  Files         179      117       -62     
  Lines        7007     4490     -2517     
  Branches     1416     1118      -298     
===========================================
- Hits         2923     2633      -290     
+ Misses       3713     1618     -2095     
+ Partials      371      239      -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TkDodo TkDodo merged commit 9dc3eaa into TanStack:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants