-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix(query-core): computed properties of QueryObserverResult #6716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query-core): computed properties of QueryObserverResult #6716
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 584cf24:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your changes are correct. Could you please add some type-tests to verify ?
cc7181e
to
584cf24
Compare
Thank you for your quick response! Type testing is a bit new, but I've added some cases. Thanks for the review. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 584cf24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6716 +/- ##
===========================================
+ Coverage 41.71% 58.64% +16.92%
===========================================
Files 179 117 -62
Lines 7007 4490 -2517
Branches 1416 1118 -298
===========================================
- Hits 2923 2633 -290
+ Misses 3713 1618 -2095
+ Partials 371 239 -132 ☔ View full report in Codecov by Sentry. |
isLoading
(isPending && isFetching) is a value calculated fromisPending
.Therefore, if isPending is false, isLoading becomes false, and if isLoading is true, isPending also becomes true, so modify the related type.