Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome as formatter #7439

Closed
wants to merge 5 commits into from
Closed

Conversation

Jungzl
Copy link
Contributor

@Jungzl Jungzl commented May 16, 2024

Biome is much faster than prettier.

Warning

It's partially supported svelte right now, so every svelte file has no indent in its script block, but I think it's acceptable.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 6:40am

Copy link

nx-cloud bot commented May 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cd7d223. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd7d223:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 41.15%. Comparing base (93674fe) to head (cd7d223).
Report is 144 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7439      +/-   ##
==========================================
- Coverage   41.42%   41.15%   -0.27%     
==========================================
  Files         184      182       -2     
  Lines        7331     7403      +72     
  Branches     1531     1552      +21     
==========================================
+ Hits         3037     3047      +10     
- Misses       3889     3944      +55     
- Partials      405      412       +7     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <88.88%> (+0.11%) ⬆️
@tanstack/eslint-plugin-query 85.46% <100.00%> (+0.17%) ⬆️
@tanstack/query-async-storage-persister 43.85% <100.00%> (-5.35%) ⬇️
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <0.00%> (ø)
@tanstack/query-core 92.95% <ø> (-0.31%) ⬇️
@tanstack/query-devtools 3.92% <ø> (-0.02%) ⬇️
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.72% <ø> (-0.06%) ⬇️
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 77.92% <ø> (-4.35%) ⬇️
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.91% <ø> (+0.10%) ⬆️
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo
Copy link
Collaborator

TkDodo commented May 16, 2024

thanks, but prettier works fast enough.

@TkDodo TkDodo closed this May 16, 2024
@Jungzl Jungzl deleted the feat/biome branch May 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment