Skip to content

fix: handle optional and non-null chaining in exhaustive-deps #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: handle optional and non-null chaining in exhaustive-deps #8365

merged 2 commits into from
Nov 28, 2024

Conversation

Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Nov 28, 2024 •
edited
Loading

fixes #8357

Fixed a false positive in the exhaustive-deps rule when using optional chaining and non-null assertions in query keys and functions.

fix: handle optional and non-null chaining in exhaustive-deps
4573ef3 
Fixed a false positive in the exhaustive-deps rule when using optional chaining and non-null assertions in query keys and functions.
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 28, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0822f5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8365

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8365

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8365

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8365

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8365

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8365

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8365

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8365

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8365

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8365

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8365

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8365

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8365

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8365

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8365

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8365

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8365

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8365

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8365

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8365

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8365

commit: 0822f5a

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.22%. Comparing base (422c879) to head (0822f5a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8365       +/-   ##
===========================================
+ Coverage   46.10%   88.22%   +42.11%     
===========================================
  Files         200       15      -185     
  Lines        7502      501     -7001     
  Branches     1712      186     -1526     
===========================================
- Hits         3459      442     -3017     
+ Misses       3668       45     -3623     
+ Partials      375       14      -361
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.22% <100.00%> (+0.04%) ⬆️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit c402a2b into main Nov 28, 2024
8 checks passed
@TkDodo TkDodo deleted the fix-optional-chaining-false-positive branch November 28, 2024 08:39
@imranbarbhuiya imranbarbhuiya mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint: exhaustive-deps false positive for optional chain
2 participants
@Newbie012 @TkDodo