Skip to content

fix(eslint-plugin-query): add name attribute for eslint config inspector #8584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2025
Merged

fix(eslint-plugin-query): add name attribute for eslint config inspector #8584

merged 5 commits into from
Feb 10, 2025

Conversation

NishargShah
Copy link
Contributor

@NishargShah NishargShah commented Jan 25, 2025 •
edited
Loading

I am working on the eslint config inspector for my big flat config and I saw many anonymous configs where one of them is related to tanstack/query so I added names in the flat configs

@NishargShah NishargShah marked this pull request as ready for review January 25, 2025 11:08
This was referenced Jan 25, 2025
Closed
Merged
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3f44147.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-10 17:43:12 UTC

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 10, 2025

View your CI Pipeline Execution ↗ for commit bb29642.

☁️ Nx Cloud last updated this comment at 2025-02-10 14:53:13 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 10, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8584

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8584

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8584

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8584

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8584

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8584

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8584

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8584

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8584

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8584

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8584

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8584

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8584

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8584

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8584

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8584

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8584

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8584

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8584

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8584

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8584

commit: 3f44147

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (2d677ae) to head (3f44147).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8584       +/-   ##
===========================================
+ Coverage   46.24%   88.03%   +41.78%     
===========================================
  Files         199       15      -184     
  Lines        7532      493     -7039     
  Branches     1720      181     -1539     
===========================================
- Hits         3483      434     -3049     
+ Misses       3670       45     -3625     
+ Partials      379       14      -365
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.03% <ø> (ø)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 8093fc2 into TanStack:main Feb 10, 2025
3 of 4 checks passed
magneticmeganlovesjhonny
magneticmeganlovesjhonny reviewed Feb 14, 2025
View reviewed changes
Copy link

@magneticmeganlovesjhonny magneticmeganlovesjhonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

+1 more reviewer

@magneticmeganlovesjhonny magneticmeganlovesjhonny magneticmeganlovesjhonny left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NishargShah @TkDodo @magneticmeganlovesjhonny