Skip to content

Revert "feat(eslint-plugin): no void queryFn" #8880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

Revert "feat(eslint-plugin): no void queryFn" #8880

merged 1 commit into from
Mar 30, 2025

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Mar 30, 2025

Reverts #8878

@github-actions github-actions bot added documentation Improvements or additions to documentation package: eslint-plugin-query labels Mar 30, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 97c8dc8.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 59s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-30 12:52:12 UTC

@TkDodo TkDodo merged commit cea2d58 into main Mar 30, 2025
4 checks passed
@TkDodo TkDodo deleted the revert-8878-feat-no-void-query-fn branch March 30, 2025 12:48
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 30, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8880

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8880

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8880

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8880

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8880

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8880

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8880

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8880

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8880

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8880

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8880

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8880

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8880

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8880

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8880

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8880

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8880

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8880

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8880

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8880

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8880

commit: 97c8dc8

@github-actions GitHub Actions
Copy link
Contributor

Sizes for commit 97c8dc8:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (747eea8) to head (97c8dc8).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8880       +/-   ##
===========================================
+ Coverage   46.59%   87.81%   +41.22%     
===========================================
  Files         200       15      -185     
  Lines        7574      509     -7065     
  Branches     1742      190     -1552     
===========================================
- Hits         3529      447     -3082     
+ Misses       3669       48     -3621     
+ Partials      376       14      -362
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 87.81% <ø> (ø)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo