Skip to content

test(react-query): fix async to promise to match TypeScript requirements in useSuspenseQueries.test.tsx #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

test(react-query): fix async to promise to match TypeScript requirements in useSuspenseQueries.test.tsx #8889

merged 2 commits into from
Mar 31, 2025

Conversation

minseong0324
Copy link
Contributor

Address ESLint warnings by refactoring async functions that don't use await:

  • Replace async error throwing functions with Promise.reject()

This maintains the same behavior while satisfying linter requirements.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c544dd7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 54s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-30 19:47:34 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 30, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8889

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8889

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8889

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8889

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8889

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8889

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8889

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8889

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8889

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8889

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8889

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8889

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8889

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8889

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8889

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8889

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8889

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8889

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8889

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8889

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8889

commit: c544dd7

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.18%. Comparing base (cd6c8c0) to head (c544dd7).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8889       +/-   ##
===========================================
+ Coverage   46.59%   84.18%   +37.58%     
===========================================
  Files         200       26      -174     
  Lines        7574      373     -7201     
  Branches     1743      110     -1633     
===========================================
- Hits         3529      314     -3215     
+ Misses       3669       50     -3619     
+ Partials      376        9      -367
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@minseong0324 minseong0324 changed the title fix(react-query): fix async to promise in useSuspenseQueries.test.tsx test(react-query): fix async to promise in useSuspenseQueries.test.tsx Mar 30, 2025
@minseong0324 minseong0324 changed the title test(react-query): fix async to promise in useSuspenseQueries.test.tsx test(react-query): fix async to promise to fix typescript ESLint warning in useSuspenseQueries.test.tsx Mar 30, 2025
@minseong0324 minseong0324 changed the title test(react-query): fix async to promise to fix typescript ESLint warning in useSuspenseQueries.test.tsx test(react-query): fix async to promise to match TypeScript requirements in useSuspenseQueries.test.tsx Mar 30, 2025
@TkDodo TkDodo merged commit cf7b375 into TanStack:main Mar 31, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minseong0324 @TkDodo