Skip to content

Revert "chore(paths): use customConditions to define internal imports… #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2025
Merged

Revert "chore(paths): use customConditions to define internal imports… #8973

merged 4 commits into from
Apr 9, 2025

Conversation

tylersayshi
Copy link
Contributor

… (#8935)"

This reverts commit 8e0c6b7.

@tylersayshi tylersayshi mentioned this pull request Apr 8, 2025
Closed
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ae1fa66.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 6m View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 13:57:59 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 8, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8973

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8973

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8973

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8973

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8973

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8973

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8973

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8973

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8973

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8973

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8973

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8973

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8973

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8973

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8973

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8973

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8973

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8973

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8973

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8973

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8973

commit: ae1fa66

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.28%. Comparing base (4ad696a) to head (ae1fa66).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8973      +/-   ##
==========================================
- Coverage   44.30%   42.28%   -2.02%     
==========================================
  Files         202      181      -21     
  Lines        8058     7752     -306     
  Branches     1775     1689      -86     
==========================================
- Hits         3570     3278     -292     
+ Misses       4060     4047      -13     
+ Partials      428      427       -1
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query 88.19% <0.00%> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 94.77% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit 0c229f4 into TanStack:main Apr 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-devtools-experimental package: angular-query-experimental package: eslint-plugin-query package: query-async-storage-persister package: query-broadcast-client-experimental package: query-codemods package: query-core package: query-devtools package: query-persist-client-core package: query-sync-storage-persister package: react-query package: react-query-devtools package: react-query-next-experimental package: react-query-persist-client package: solid-query package: solid-query-devtools package: solid-query-persist-client package: svelte-query package: svelte-query-devtools package: svelte-query-persist-client package: vue-query package: vue-query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylersayshi @TkDodo