Skip to content

test(query-core/queriesObserver): use precise time in 'advanceTimersByTimeAsync' #9429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2025
Merged

test(query-core/queriesObserver): use precise time in 'advanceTimersByTimeAsync' #9429

merged 3 commits into from
Jul 15, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jul 14, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 85d0295

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 40s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-15 12:10:37 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 14, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9429

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9429

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9429

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9429

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9429

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9429

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9429

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9429

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9429

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9429

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9429

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9429

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9429

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9429

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9429

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9429

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9429

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9429

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9429

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9429

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9429

commit: 85d0295

@codecov Codecov
Copy link

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (9dcd588) to head (85d0295).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9429       +/-   ##
===========================================
+ Coverage   45.29%   59.56%   +14.26%     
===========================================
  Files         208      137       -71     
  Lines        8279     5517     -2762     
  Branches     1871     1486      -385     
===========================================
- Hits         3750     3286      -464     
+ Misses       4084     1929     -2155     
+ Partials      445      302      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.00% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 97.69% <ø> (ø)
@tanstack/query-devtools 3.55% <ø> (ø)
@tanstack/query-persist-client-core 79.47% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.95% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.13% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.07% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sukvvon sukvvon force-pushed the test/query-core-queriesObserver-use-precise-time-advanceTimersByTimeAsync branch from 9e19851 to 27db3cd Compare July 14, 2025 02:56
@manudeli manudeli merged commit c65869e into TanStack:main Jul 15, 2025
7 checks passed
@sukvvon sukvvon deleted the test/query-core-queriesObserver-use-precise-time-advanceTimersByTimeAsync branch July 17, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manudeli manudeli manudeli approved these changes

Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sukvvon @manudeli