Skip to content

test(svelte-query/createMutation): improve callback assertions with 'toHaveBeenNthCalledWith' and apply shorthand property syntax in FailureExample #9630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

test(svelte-query/createMutation): improve callback assertions with 'toHaveBeenNthCalledWith' and apply shorthand property syntax in FailureExample #9630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f73f82
test(svelte-query/createMutation): improve callback assertions with '…
sukvvon Sep 8, 2025
817a0cf
Merge branch 'main' into test/svelte-query-createMutation-nth-asserti…
sukvvon Sep 8, 2025
d049df2
Merge branch 'main' into test/svelte-query-createMutation-nth-asserti…
sukvvon Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte-query/tests/createMutation/FailureExample.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
const queryClient = new QueryClient()
setQueryClientContext(queryClient)
const mutation = createMutation({ mutationFn: mutationFn })
const mutation = createMutation({ mutationFn })
</script>

<button on:click={() => $mutation.mutate({ count: ++$count })}>Mutate</button>
Expand Down
14 changes: 6 additions & 8 deletions packages/svelte-query/tests/createMutation/createMutation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,14 @@ describe('createMutation', () => {
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()

expect(onSuccessMock).toHaveBeenCalledTimes(3)

expect(onSuccessMock).toHaveBeenCalledWith(1)
expect(onSuccessMock).toHaveBeenCalledWith(2)
expect(onSuccessMock).toHaveBeenCalledWith(3)
expect(onSuccessMock).toHaveBeenNthCalledWith(1, 1)
expect(onSuccessMock).toHaveBeenNthCalledWith(2, 2)
expect(onSuccessMock).toHaveBeenNthCalledWith(3, 3)

expect(onSettledMock).toHaveBeenCalledTimes(3)

expect(onSettledMock).toHaveBeenCalledWith(1)
expect(onSettledMock).toHaveBeenCalledWith(2)
expect(onSettledMock).toHaveBeenCalledWith(3)
expect(onSettledMock).toHaveBeenNthCalledWith(1, 1)
expect(onSettledMock).toHaveBeenNthCalledWith(2, 2)
expect(onSettledMock).toHaveBeenNthCalledWith(3, 3)
})

test('Set correct values for `failureReason` and `failureCount` on multiple mutate calls', async () => {
Expand Down
Loading