Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react-router): onEnter should have the router context defined #2295

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

SeanCassiere
Copy link
Member

Test to reinforce #1529.

Closes #1529

Copy link

nx-cloud bot commented Sep 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16026c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 9, 2024

Open in Stackblitz

More templates

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2295

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2295

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2295

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2295

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2295

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2295

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2295

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2295

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2295

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2295

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2295

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2295

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2295

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2295

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2295

commit: 16026c7

@SeanCassiere SeanCassiere marked this pull request as ready for review September 9, 2024 01:35
@SeanCassiere SeanCassiere merged commit 0e16429 into main Sep 9, 2024
5 checks passed
@SeanCassiere SeanCassiere deleted the test-on-enty-context-values branch September 9, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the context in the onEnter is callback on the Route definition returns undefined on first-load during runtime
1 participant