[useRowSelect] `Select All` operation can be optimized

[gargroh]

Using useRowSelect, Select All feature, when used with good amount of rows(mine case is with ~119K rows), then takes a long time to apply action. Following are the major places which are time consuming :-

1. 
   It is possible to optimize here by checking flatRowPaths.length === selectedRowPaths.length or in any other way ?

2

@tannerlinsley , let me know your thoughts on it, will open PR accordingly..

[tannerlinsley]

Yeah there is definitely room for improvement here. Tanner Linsley

…

On Dec 3, 2019, 5:49 AM -0700, gargroh ***@***.***>, wrote: Using useRowSelect, Select All feature, when used with good amount of rows(mine case is with ~119K rows), then takes a long time to apply action. Following are the major places which are time consuming :- 1. It is possible to optimize here by checking flatRowPaths.length === selectedRowPaths.length or in any other way ? 2 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[tannerlinsley]

I think one good solution to this is changing selectedRowPaths to a Set(). The hard part with sets is that they are not particularly intuitive for immutable operations, but we can mask that for the most part and just document that it's a set. Not hard to do new Set(existingSet) to get a new copy.

[tannerlinsley]

I'll push that change in a bit.

[tannerlinsley]

Just pushed a new beta version that uses Set(). It should be a lot faster.

[gargroh]

Thank you @tannerlinsley