Skip to content

fix(virtual-core): set useScrollendEvent default to false for bette… #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

fix(virtual-core): set useScrollendEvent default to false for bette… #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f44dea3
fix(virtual-core): set `useScrollendEvent` default to false for bette…
piecyk Mar 12, 2025
43bf4e3
Add changeset
piecyk Mar 13, 2025
889c2fd
ci: apply automated fixes
autofix-ci[bot] Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-melons-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/virtual-core': patch
---

fix(virtual-core): set `useScrollendEvent` default to false for bette…
2 changes: 1 addition & 1 deletion docs/api/virtualizer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ The implementation of this option is driven by the need for a reliable mechanism
useScrollendEvent: boolean
```

This option allows you to switch to use debounced fallback to reset the isScrolling instance property after `isScrollingResetDelay` milliseconds. The default value is `true`.
Determines whether to use the native scrollend event to detect when scrolling has stopped. If set to false, a debounced fallback is used to reset the isScrolling instance property after isScrollingResetDelay milliseconds. The default value is `false`.

The implementation of this option is driven by the need for a reliable mechanism to handle scrolling behavior across different browsers. Until all browsers uniformly support the scrollEnd event.

Expand Down
2 changes: 1 addition & 1 deletion packages/virtual-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ export class Virtualizer<
isScrollingResetDelay: 150,
enabled: true,
isRtl: false,
useScrollendEvent: true,
useScrollendEvent: false,
useAnimationFrameWithResizeObserver: false,
...opts,
}
Expand Down