This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
V200 #32
Closed
V200 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ def delete | |||
|
|
|||
| def create(image_id:, instance_type:, security_groups:, user_data:, | |||
| keypair:, iam_instance_profile:, classic_link_vpc_id: nil, | |||
| classic_link_sg_ids: nil, **unused_values) | |||
| classic_link_sg_ids: nil, spot_price: nil, ebs_optimized: true, **unused_values) | |||
There was a problem hiding this comment.
The docs say the default for this option is false, but it looks like it's true here
There was a problem hiding this comment.
good catch. I'm okay with fixing either one.
@Tapjoy/eng-group-ops @obrie do we want to default to true or false?
atayarani
force-pushed
the
v200
branch
5 times, most recently
from
6bddf62
to
3b39f5e
Compare
atayarani
force-pushed
the
v200
branch
2 times, most recently
from
d08bfd5
to
e5a839b
Compare
* Make TASS use SDK for spot fleet requests * fix specs
…ot fleet user data scripts.
* Make TASS use SDK for spot fleet requests * fix specs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is represents the merge of the integration branch for v2.0.0 to master. Other branches should be based on v2.0.0 until it's ready to ship.