Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix chat completion request schema #46

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: fix chat completion request schema #46

merged 2 commits into from
May 24, 2024

Conversation

Dttbd
Copy link
Collaborator

@Dttbd Dttbd commented May 23, 2024 •
edited by jameszyao
Loading

Pull Request

PR Description

Remove save_logs field from chat completion request schema.

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING.md guidelines.
  • I have tested my changes locally to ensure they are effective.
  • I have updated the necessary documentation (if applicable).

@Dttbd Dttbd requested a review from SimsonW May 23, 2024 09:49
@Dttbd Dttbd requested a review from jameszyao May 23, 2024 09:50
jameszyao
jameszyao previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jameszyao jameszyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dttbd Dttbd force-pushed the feat/fix_chat_complition_request_schema branch from cdc465f to 3c42081 Compare May 23, 2024 09:57
@taskingaijc taskingaijc force-pushed the feat/fix_chat_complition_request_schema branch from 54b95cb to 4ed82f8 Compare May 24, 2024 05:36
@taskingaijc taskingaijc force-pushed the feat/fix_chat_complition_request_schema branch from 4ed82f8 to 632ee34 Compare May 24, 2024 07:44
jameszyao
jameszyao approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@jameszyao jameszyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameszyao jameszyao merged commit d0d957d into master May 24, 2024
1 check passed
@jameszyao jameszyao deleted the feat/fix_chat_complition_request_schema branch June 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameszyao jameszyao jameszyao approved these changes

@SimsonW SimsonW Awaiting requested review from SimsonW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dttbd @jameszyao @taskingaijc