You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Proposed contribution: financial-analysis guidance and data-quality reporting
#1553
While using v0.7.0 locally, I developed several improvements that I’d like to offer for upstream review. Before opening a PR, I’d appreciate your feedback on the scope.
Proposed changes
Financial-analysis guidance: Require exact reporting periods, same-quarter year-over-year comparisons, supporting values for growth calculations, and consistency between narrative figures and summary tables.
Earnings quality: Ask the fundamentals analyst to explain disclosed unusual gains, charges, and tax effects without inventing adjusted earnings.
Market-data availability: Explicitly distinguish missing or delayed OHLCV data from confirmed market closures and identify the latest available session.
Price freshness: Add notices for potentially incomplete same-day OHLCV data and instruct the trader to state PENDING FRESH-PRICE VERIFICATION when current executable quotes are unavailable.
HTML reporting: Add a prominent “Data Quality & Limitations” section that extracts recognized warnings from Market Analyst and Trader reports.
Docker report access: Mount the reports directory into the host project folder.
Implementation scope
The changes are on my local tradingagents-local-improvements branch, based on e8f5503:
Three commits
Seven files changed
153 added lines
Three new HTML-report regression tests
Validation and limitations
Local development output recorded 33 passing tests. A manual HTML regeneration check also confirmed that the limitations section and fresh-price warning appeared while preserving all five report sections. Full-suite and lint validation still need to be completed before submission.
The financial-analysis and trader safeguards are prompt instructions, so they do not enforce numerical correctness or block execution. HTML warning extraction depends on exact warning markers surviving in agent reports. The same-day OHLCV notice currently uses the New York date rather than an exchange-session calendar, so it is conservative and may also appear after the close.
Would you be interested in a PR for these changes? I’m happy to split the analysis and snapshot guidance, HTML reporting, and Docker mount into separate PRs if that would make review easier.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hi TradingAgents maintainers,
While using v0.7.0 locally, I developed several improvements that I’d like to offer for upstream review. Before opening a PR, I’d appreciate your feedback on the scope.
Proposed changes
Financial-analysis guidance: Require exact reporting periods, same-quarter year-over-year comparisons, supporting values for growth calculations, and consistency between narrative figures and summary tables.
Earnings quality: Ask the fundamentals analyst to explain disclosed unusual gains, charges, and tax effects without inventing adjusted earnings.
Market-data availability: Explicitly distinguish missing or delayed OHLCV data from confirmed market closures and identify the latest available session.
Price freshness: Add notices for potentially incomplete same-day OHLCV data and instruct the trader to state PENDING FRESH-PRICE VERIFICATION when current executable quotes are unavailable.
HTML reporting: Add a prominent “Data Quality & Limitations” section that extracts recognized warnings from Market Analyst and Trader reports.
Docker report access: Mount the reports directory into the host project folder.
Implementation scope
The changes are on my local tradingagents-local-improvements branch, based on e8f5503:
Three commits
Seven files changed
153 added lines
Three new HTML-report regression tests
Validation and limitations
Local development output recorded 33 passing tests. A manual HTML regeneration check also confirmed that the limitations section and fresh-price warning appeared while preserving all five report sections. Full-suite and lint validation still need to be completed before submission.
The financial-analysis and trader safeguards are prompt instructions, so they do not enforce numerical correctness or block execution. HTML warning extraction depends on exact warning markers surviving in agent reports. The same-day OHLCV notice currently uses the New York date rather than an exchange-session calendar, so it is conservative and may also appear after the close.
Would you be interested in a PR for these changes? I’m happy to split the analysis and snapshot guidance, HTML reporting, and Docker mount into separate PRs if that would make review easier.
All reactions