-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move deep search results to SearchView
#4042
Move deep search results to SearchView
#4042
Conversation
I am currently removing all things related to the old search from the I think that it is helpful to be able get back to the search in general, but I don't know if changing the behavior of Since the current implementation does not work with the new deep search in the |
309393d
to
766b6a8
Compare
@seelchen can you please check this codacy issue with your last pr #4020 https://github.com/TeamAmaze/AmazeFileManager/pull/4044/checks?check_run_id=20382785390 |
7a0fc58
to
e3df339
Compare
It is now case-insensitive like the search without "regex"
b522935
to
0d40d19
Compare
This is ready for review! I know that it looks like a lot of changes, but most of it is actually just removing an if statement and reducing the indents for the whole block. Since git stores the diff line-based, every line where the indents are reduced are marked as a change... |
Great work! Is it possible to include regex search in filter search and index search? Currently it only works when user does deep search. It leaves user confused. We either need to mention this in settings that regex will only work in deep search or find a way to include regex search in filter and index search. |
I implemented this in #4050 so that this PR won't become even bigger. If you want, I can completely disable regex search here and it would be readded when #4050 is merged. |
Description
This PR changes the deep search to show the results in the
SearchView
and not theMainView
anymore. The deep search is refactored to run in aCoroutine
instead of anAsyncTask
.Issue tracker
Fixes #4041
Fixes #3357
Automatic tests
Manual tests
Device:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck