This repository was archived by the owner on Nov 15, 2024. It is now read-only.
Feature/nr 263403 nr code errors #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect codeError posts delete via stream since we don't have codeError in mongo anymore
Some backward compatability
Fix more backward compatability
Use attributes to access this.codeError
- Restore codeErrorId
bcanzanella
reviewed
May 9, 2024
- Delete unused associate_code_error
CalvinAllen
approved these changes
May 9, 2024
cstryker
reviewed
May 9, 2024
| throw this.errorHandler.error('parameterRequired', { reason: 'parentPostId is required for Grok reinitialization' }); | ||
| } | ||
|
|
||
| const post = await this.data.posts.getById(this.request.body.parentPostId); | ||
| const codeError = await this.data.codeErrors.getById(post.get('codeErrorId')); | ||
| this.log("PostPostRequest - handleResponse - reinitializeGrok - looking up codeError"); | ||
| const codeError = await this.data.codeErrors.getById(post.get('codeErrorId')); // TODO not in errorGuid mode |
There was a problem hiding this comment.
not sure i understand the TODO here
|
|
||
| // When we force a reinitialization on a Code Error with Grok, we need to return | ||
| // the original Parent Post and the Code Error associated with it. The client | ||
| // doesn't know how to handle the response without them. | ||
| this.responseData.post = post.getSanitizedObject({ request: this.request }); | ||
| this.responseData.codeError = codeError.getSanitizedObject({ request: this.request }); | ||
| this.responseData.codeError = codeError.getSanitizedObject({ request: this.request }); // TODO not in errorGuid mode |
- Remove TODOs that don't need to be.
cstryker
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea here is that post /POST for a code error is idempotent and won't create a duplicate toplevel post for a error discussion based on the NR errorGuid. The toplevel post stores the errorGuid to link the NR error with the conversation.