Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with scikit-learn 0.21 #313

Merged
merged 5 commits into from
May 27, 2019
Merged

Conversation

ivanprado
Copy link
Collaborator

@ivanprado ivanprado commented May 27, 2019

Some changes have been introduced to be compatible with scikit-learn 0.21:

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #313 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   97.09%   97.16%   +0.07%     
==========================================
  Files          44       44              
  Lines        2856     2862       +6     
  Branches      542      544       +2     
==========================================
+ Hits         2773     2781       +8     
+ Misses         45       43       -2     
  Partials       38       38
Impacted Files Coverage Δ
eli5/sklearn/explain_prediction.py 97.92% <100%> (+0.05%) ⬆️
eli5/sklearn/transform.py 100% <0%> (+5.71%) ⬆️

@ivanprado ivanprado changed the title Randomized(LogisticRegression|Lasso) makes test fail for scikit-learn 0.21 [WIP] Randomized(LogisticRegression|Lasso) makes test fail for scikit-learn 0.21 May 27, 2019
@ivanprado ivanprado changed the title [WIP] Randomized(LogisticRegression|Lasso) makes test fail for scikit-learn 0.21 Compatibility with scikit-learn 0.21 May 27, 2019
@lopuhin lopuhin requested review from kmike and lopuhin May 27, 2019 15:31
Copy link
Contributor

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ivanprado 👍

@kmike kmike merged commit 360d080 into TeamHG-Memex:master May 27, 2019
@kmike
Copy link
Contributor

kmike commented May 27, 2019

Thanks @ivanprado!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants