Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Java 8 APIs. #3817

Merged
merged 3 commits into from
Nov 1, 2020
Merged

Use Java 8 APIs. #3817

merged 3 commits into from
Nov 1, 2020

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jun 25, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

Testing apk

debug.zip

Agreement

@wb9688
Copy link
Contributor

wb9688 commented Jun 27, 2020 •
edited
Loading

Please squash some commits, so that all Date/Time related changes are one commit, all removeIf() related changes are one commit, etc.

Btw is there any reason for not using a newer Gradle version?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Jun 27, 2020 •
edited
Loading

Please squash some commits, so that all Date/Time related changes are one commit, all removeIf() related changes are one commit, etc.

Okay.

Btw is there any reason for not using a newer Gradle version?

No, it was set to that specific version when updating the Android Gradle plugin.

Should I set it to a newer version?

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 2 times, most recently from 098aeb4 to a1c07a9 Compare July 19, 2020 00:20
opusforlife2
opusforlife2 reviewed Sep 13, 2020
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 3 times, most recently from c589172 to cefe1e7 Compare September 14, 2020 06:11
@Stypox Stypox added this to the 0.20.1 milestone Sep 14, 2020
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 5 times, most recently from 57b9f9d to b7cef3b Compare October 4, 2020 02:52
@Stypox Stypox removed this from the 0.20.1 milestone Oct 4, 2020
@Isira-Seneviratne
Copy link
Member Author

@Stypox I'm merging the changes from the master branch.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 6 times, most recently from 18e8d33 to 745ec05 Compare October 9, 2020 03:26
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 2 times, most recently from a1383ca to 046bae6 Compare October 18, 2020 10:55
Stypox
Stypox requested changes Oct 18, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes to build.gradle and gradle/wrapper/gradle-wrapper.properties, since the grandle update is covered by #4508

@wb9688
Copy link
Contributor

wb9688 commented Oct 18, 2020

@Stypox: It's not possible to have these improvements without those changes

@Stypox
Copy link
Member

Stypox commented Oct 18, 2020

@wb9688 I know, I just keep those files modified locally without pushing them 😉

@Isira-Seneviratne
Copy link
Member Author

@wb9688 I know, I just keep those files modified locally without pushing them 😉

The thing is, the Gradle plugin version in the dev branch is currently 3.6.3, but API desugaring requires at least 4.0.0.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_APIs branch 4 times, most recently from 1969d5e to bde384f Compare October 28, 2020 11:41
@Isira-Seneviratne Isira-Seneviratne requested review from Stypox and removed request for wb9688 October 31, 2020 04:17
@Stypox
Copy link
Member

Stypox commented Oct 31, 2020

@Isira-Seneviratne could you upload a new apk? After that I will review, test and merge

@Isira-Seneviratne
Copy link
Member Author

Sure.

@Isira-Seneviratne
Copy link
Member Author

I uploaded a new APK.

Stypox
Stypox approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Code looks good. I tested all the activities you changed on Android 4.4, 7.0 and 10, and everything worked fine. :-D

@Stypox
Copy link
Member

Stypox commented Nov 1, 2020

@TobiGr merge (now GitHub waits indefinitely for synk to pass, but since you disabled the webhook it won't ever report a status)

@TobiGr TobiGr merged commit e97d0b9 into TeamNewPipe:dev Nov 1, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_Java_8_APIs branch November 1, 2020 23:49
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opusforlife2 opusforlife2 opusforlife2 left review comments

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Isira-Seneviratne @wb9688 @Stypox @opusforlife2 @TobiGr