Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DisplayCutoutCompat in VideoPlayerImpl. #4338

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Use DisplayCutoutCompat in VideoPlayerImpl. #4338

merged 1 commit into from
Oct 5, 2020

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use DisplayCutoutCompat instead of DisplayCutout in VideoPlayerImpl.

Testing apk

debug.zip

Agreement

Stypox
Stypox reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it impossible for devices with an Android version < P to have insets?

@blackbox87
Copy link

Isn't it impossible for devices with an Android version < P to have insets?

The Nokia 7.1 has a notch and was originally sold with Android Oreo, so I guess there's a few other devices too. But most of these devices did receive updates to Android 9 and 10.

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Sep 29, 2020 •
edited
Loading

Isn't it impossible for devices with an Android version < P to have insets?

Window insets were actually introduced in API level 20. Display cutouts were introduced in API level 28.

Stypox
Stypox previously approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I see, then the code looks good to me. Thank you!

@Stypox Stypox added this to the 0.20.1 milestone Sep 29, 2020
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Sep 29, 2020
@Stypox Stypox removed this from the 0.20.1 milestone Oct 4, 2020
@Isira-Seneviratne
Copy link
Member Author

@Stypox I fixed a merge conflict.

@TobiGr TobiGr merged commit dd55ad6 into TeamNewPipe:dev Oct 5, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_DisplayCutoutCompat branch October 5, 2020 13:05
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Awaiting requested review from Stypox

Assignees
No one assigned
Labels
player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Isira-Seneviratne @blackbox87 @TobiGr @Stypox