Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also delete stream state when deleting stream history #4413

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Oct 5, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes an inconsistent behaviour when deleting a stream from history: the stream state was not being deleted, thus potentially leaving trace of the fact that that specific video was watched. Also see #4393. This PR just adds a line to also delete the stream state when deleting a single stream from the history fragment.

Fixes the following issue(s)

Fixes #4393

Testing apk

@e-edgren
app-debug.zip

Agreement

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@Stypox Stypox merged commit 724a260 into TeamNewPipe:dev Oct 10, 2020
This was referenced Nov 10, 2020
@Stypox Stypox deleted the delete-stream-state branch August 4, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to reset a played video and/or delete the watch history for a video
2 participants