Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example of how to use Markdown checkbox #4431

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Added an example of how to use Markdown checkbox #4431

merged 2 commits into from
Oct 8, 2020

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Fixes the following issue(s)

  • Some users don't know how to properly tick the check boxes. So I've modified the issue templates to give an example each.

Agreement


- [ ] I am using the latest version. <!-- compare Releases page and your version given in About in the app drawer -->
- [x] I am using the latest version. <!-- compare Releases page and your version given in About in the app drawer -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if pre-checking one of the boxes is the best idea, as people might then skip that item

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the least problematic of the items. People generally do ensure they are on the latest version because it is easy to check. But checking the repo for duplicates or reading the contribution document takes time.

@Stypox
Copy link
Member

Stypox commented Oct 8, 2020

Can this be merged? I agree with you @opusforlife2 , that having a checked checkbox does not hurt in terms of the user checking, but is a good example

@opusforlife2
Copy link
Collaborator Author

I would love to have an automatically replaced Version in the template like youtube-dl, but that involves coding and is beyond my abilities.

@Stypox
Copy link
Member

Stypox commented Oct 8, 2020

@opusforlife2 that can be done in the future, ok

@Stypox Stypox merged commit f4620be into TeamNewPipe:dev Oct 8, 2020
@opusforlife2 opusforlife2 deleted the checkbox_example branch October 8, 2020 14:15
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants