Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on how to use a local NewPipe Extractor version #4528

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Oct 16, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Added a few lines on how to use a local extractor version for debugging and developing the extractor and testing those changes in the app.

Due diligence

Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling of NewPipe Extractor

@opusforlife2 opusforlife2 changed the title Add info to build.gradle and settings.gradle on how to use a local Add info on how to use a local NewPipe Extractor version Oct 16, 2020
@Stypox
Copy link
Member

Stypox commented Oct 16, 2020

Oh, good to know, I always pushed changed and then used Jitpack 😅

@wb9688
Copy link
Contributor

wb9688 commented Oct 16, 2020

@Stypox: Have you not read NPE's readme?

@TobiGr TobiGr merged commit c4af93c into dev Oct 16, 2020
@opusforlife2
Copy link
Collaborator

opusforlife2 commented Oct 16, 2020

Why can I delete the local-extractor branch? Never seen that before.

Oh. It's on the main repo. You don't use a forked repo, @TobiGr?

@TobiGr TobiGr deleted the local-extractor branch October 16, 2020 15:29
@TobiGr
Copy link
Contributor Author

TobiGr commented Oct 16, 2020

Correct. forgot to delete it.

@opusforlife2
Copy link
Collaborator

You don't use a forked repo

^

This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants