-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More miscellaneous little fixes and improvements #4710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember reading a thing about that, but I don't remember where. |
I used PNGs since there is no way to use vector drawables in notifications on android 4.4 |
@Stypox 🤔 Interesting... |
I decided to remove the vector commit, I rebased on top of latest commits, and regenerated a new APK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I also tested the apk in the activities you changed and it works fine. Thank you!
@TobiGr merge (Can synk be disabled or fixed? It is preventing me from merging any PR) |
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
app-debug.zip
Due diligence