Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More miscellaneous little fixes and improvements #4710

Merged
merged 7 commits into from
Oct 31, 2020
Merged

More miscellaneous little fixes and improvements #4710

merged 7 commits into from
Oct 31, 2020

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Oct 29, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Don't use dumb loser numbers when checking the Android OS version
  • Replace a getSystemService(LayoutInflater) with LayoutInflater.from
  • Updates the viewpager2 to use the preferred version of the state adapter
  • Add missing app:iconSpaceReserved settings
  • Some miscellaneous code improvements

Fixes the following issue(s)

  • None that I'm aware of

APK testing

app-debug.zip

Due diligence

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

@Stypox Can you please have a look at c9d9c59? I think there was a reason, why you didn't use vector drawables.

@TacoTheDank
Copy link
Member Author

I remember reading a thing about that, but I don't remember where.

@Stypox
Copy link
Member

Stypox commented Oct 30, 2020

I used PNGs since there is no way to use vector drawables in notifications on android 4.4

@TacoTheDank
Copy link
Member Author

@Stypox 🤔 Interesting...

@TacoTheDank
Copy link
Member Author

I decided to remove the vector commit, I rebased on top of latest commits, and regenerated a new APK.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I also tested the apk in the activities you changed and it works fine. Thank you!

@Stypox
Copy link
Member

Stypox commented Oct 31, 2020

@TobiGr merge (Can synk be disabled or fixed? It is preventing me from merging any PR)

@TobiGr TobiGr merged commit 1500ce7 into TeamNewPipe:dev Oct 31, 2020
@TacoTheDank TacoTheDank deleted the more-cleanup branch November 1, 2020 02:51
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants