Handle youtube stream urls in "vnd.youtube:videoId" format. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official YouTube app accept intents in this format, which causes other developers to use it.
wb9688
reviewed
Jun 27, 2020
Comment on lines
+55
to
+63
| @Override | ||
| public LinkHandler fromUrl(String url) throws ParsingException { | ||
| if (url.startsWith(BASE_YOUTUBE_INTENT_URL)){ | ||
| return super.fromUrl(url, BASE_YOUTUBE_INTENT_URL); | ||
| } else { | ||
| return super.fromUrl(url); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is unnecessary and pointless as far as I could tell.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it on my Android 10 device by entering the "vnd.youtube:Jb8BqYYqDMQ" into the browser and opening it with NewPipe
app-debug.zip
No changes required in frontend
closes TeamNewPipe/NewPipe#3091
@Offerel