Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Java 8 Date/Time API. #417

Merged
merged 8 commits into from
Nov 1, 2020
Merged

Use the Java 8 Date/Time API. #417

merged 8 commits into from
Nov 1, 2020

Conversation

Isira-Seneviratne
Copy link
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@wb9688
Copy link
Contributor

wb9688 commented Oct 18, 2020

D8/R8 supports desugaring up to Java 12. (However AGP only supports Java 8 due to bootclasspath, so it's limited to Java 8 for Android code i.e. NewPipe, while you could use Java 12 in non-Android code i.e. NewPipeExtractor.)

@Isira-Seneviratne
Copy link
Member Author

D8/R8 supports desugaring up to Java 12. (However AGP only supports Java 8 due to bootclasspath, so it's limited to Java 8 for Android code i.e. NewPipe, while you could use Java 12 in non-Android code i.e. NewPipeExtractor.)

So should I set the JDK version to 12 instead of 8?

@Isira-Seneviratne Isira-Seneviratne mentioned this pull request Oct 18, 2020
Merged
5 tasks
@Isira-Seneviratne
Copy link
Member Author

The test failures appear to be due to outdated links being used.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_Date_Time_API branch 3 times, most recently from 3c783c5 to 26ab090 Compare October 20, 2020 02:49
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_Date_Time_API branch 2 times, most recently from f130eea to 16e23e2 Compare October 28, 2020 11:19
@Isira-Seneviratne
Merge branch 'dev' of https://github.com/TeamNewPipe/NewPipeExtractor …
61dcbbb 
…into dev

� Conflicts:
�	extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Java_8_Date_Time_API branch 2 times, most recently from 21dca44 to 038d81f Compare October 29, 2020 07:27
Stypox
Stypox approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I haven't yet tested though. Thank you!

@TobiGr TobiGr merged commit 8cbdec6 into TeamNewPipe:dev Nov 1, 2020
@TobiGr
Copy link
Contributor

TobiGr commented Nov 1, 2020 •
edited
Loading

Ah. Well. That was not a good review 😆 We missed, that the PR does not even build and breaks some tests...

Edit: fixed the build. We need to fix the tests, / functionality though.

@Isira-Seneviratne Isira-Seneviratne deleted the Use_Java_8_Date_Time_API branch November 2, 2020 23:43
@opusforlife2 opusforlife2 mentioned this pull request Nov 16, 2020
Merged
3 tasks
@opusforlife2 opusforlife2 mentioned this pull request Nov 16, 2020
Closed
@kapodamy kapodamy mentioned this pull request Nov 20, 2020
Open
@ShareASmile ShareASmile mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B0pol B0pol B0pol left review comments

@Stypox Stypox Stypox approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Isira-Seneviratne @wb9688 @TobiGr @Stypox @B0pol