Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and improved bootstrap integration #2

Merged
merged 11 commits into from Feb 12, 2017

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Feb 12, 2017

Texts for features completed.
Improved design for small screens.

Add all texts and improvements for header.

Some code improvements.

@TheAssassin
Copy link
Member

Looks like you're making progress. Could be merged as soon as there's a phone in the phone container (you could use the thing from https://newpipe.schabi.org/).

A few suggestions to make other developers happy:

@TobiGr
Copy link
Member Author

TobiGr commented Feb 12, 2017

The social media stuff is disabled and not shown. It's just there, in case we will need it in the future. So if we need it, I will make them opt-in then.
I'll fix the other suggestions as soon as I can.

shadow for 'get it on FDroid' button
@TobiGr
Copy link
Member Author

TobiGr commented Feb 12, 2017

Everything should be fixed now.
Except for the phone.

@TobiGr
Copy link
Member Author

TobiGr commented Feb 12, 2017

Phone added. Should be fine now.

@TheAssassin
Copy link
Member

Cool. But I just found one more caveat: I cannot find a license for the phone animation. Thus, the distribution and use of the phone stuff might break copyright laws (although I really doubt that). I will merge your PR now, but will create a separate issue for that.

@TheAssassin TheAssassin merged commit 4044753 into TeamNewPipe:master Feb 12, 2017
@theScrabi
Copy link
Member

Uh that phone video also has to be remade, it's a horribly old version shown there :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants