New command api #3
Conversation
| for (Diagnostic<? extends JavaFileObject> diagnostic : diagnosticsCollector.getDiagnostics()) { | ||
| switch (diagnostic.getKind()) { | ||
|
|
||
| System.out.println("CG> redirect-streams -i \"err\" \"compilation\""); |
There was a problem hiding this comment.
Are " really mandatory for err and compilation parameters?
There was a problem hiding this comment.
No, do you want them removed?
| for (Diagnostic<? extends JavaFileObject> diagnostic : diagnosticsCollector.getDiagnostics()) { | ||
| switch (diagnostic.getKind()) { | ||
|
|
||
| System.out.println("CG> redirect-streams -i \"err\" \"compilation\""); |
There was a problem hiding this comment.
As for annotate, i would prefer long option --inputs=err
| } | ||
| System.out.println("CG> redirect-streams -r -i \"err\" \"compilation\""); |
There was a problem hiding this comment.
I would prefer --reset instead of -r. I though the reset option stands for "Cancel all the redirections". In this case, is the rest of the command mandatory?
There was a problem hiding this comment.
with this parameters, only the redirection between err and compilation is cancelled
There was a problem hiding this comment.
Ok. In this case, only err has been redirected so…
There was a problem hiding this comment.
Not if the caller redirect an other stream before
| case ERROR: | ||
| type = "ERROR"; |
There was a problem hiding this comment.
In the doc, the type seems to be in lowercase… maybe it's case insensitive?
| diagnostic.getKind().name().toLowerCase(), | ||
| diagnostic.getMessage(null), | ||
| line, | ||
| String.join("", Collections.nCopies((int)diagnostic.getColumnNumber() - 1, " ")) |
There was a problem hiding this comment.
Is it for padding? doesn't String.format make the job?
Something like:
String.format("%"+diagnostic.getColumnNumber()+"s", " ")
There was a problem hiding this comment.
It's to reproduce the javac output format, I don't know this syntax?!
There was a problem hiding this comment.
%s will print the string as it is. %<n>s will print the string as it is, but if the string has less than n characters, the output will be padded on the left.
No description provided.