Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http4k - tidy, adding virtual hosting to apache server implementation #5980

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Conversation

daviddenton
Copy link
Contributor

... as the TFB build is actually inconsistent with the way tests are run in the benchmarking

adding virtual hosting to apache server implementation
@daviddenton
Copy link
Contributor Author

After a tiny fight with gradle and docker, this is now ready to merge. It should fix the http4k and http4k-apache benchmarks :)

@NateBrady23 NateBrady23 merged commit f5045eb into TechEmpower:master Sep 8, 2020
tomciopp pushed a commit to tomciopp/FrameworkBenchmarks that referenced this pull request Oct 21, 2020
…TechEmpower#5980)

* tidy imports and code
adding virtual hosting to apache server implementation

* upgrade http4k

* readded missed project directory
@BogdanJava
Copy link

Hi @daviddenton after upgrading our http4k version I stumbled upon this issue while trying to deploy our app to k8s - liveness probe was failing with 421 "Not authoritative". Is there a proper way to configure my app to avoid this error or I should simply use Apache4Server instead?

@daviddenton
Copy link
Contributor Author

I'm not really an expert on the configuration of the Apache backend tbh.... I tend to use undertow as a first option whenever I can (it's easier to configure). Feel free to switch obvs but Apache 4 isn't being developed any more so if there were cves from it I'm not sure it would get updated by the Apache team.

Sorry for not being more helpful - please let us know if you fix it in v5 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants