fix: handle engine error properly #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbence94
reviewed
Jun 30, 2021
tunderdomb
requested changes
Jul 1, 2021
src/Avast.js
Outdated
| this.resultMap.delete('error') | ||
|
|
||
| if (scanError) { | ||
| throw scanError |
There was a problem hiding this comment.
Ebben a method-ban minden error unhandled lesz, mivel ahol hívva van, ott nincs kezelve:
return await this._scanFile(task.filePath)Az await miatt helyben kéne kezelni a hibákat try-cathc-el, vagy ezen a metóduson belül kell kezelni a hibákat!
tgabi333
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of Engine Error, the library was creating an unhandledPromiseRejection, since the error originated in _processData which inside of an even listener, and it didn't properly propagate.