Skip to content

Conversation

petewilcock
Copy link
Contributor

@petewilcock petewilcock commented May 15, 2022

Adds support for experimental --architecture flag, and adds a module output for the repo URL.

Resolves #5
Resolves #4

@petewilcock petewilcock merged commit 329a625 into master May 15, 2022
@petewilcock petewilcock deleted the 0.0.8 branch May 15, 2022 08:39
@blimmer
Copy link

blimmer commented May 15, 2022

I think there's an issue with this change:

module.docker_pullpush.null_resource.docker_pullpush (local-exec): Executing: ["bash" "-c" ".terraform/modules/docker_pullpush/docker_pullpush.sh wordpress:php7.4-apache us-west-2 12345678910 travelblog-serverless-wordpress base  linux/amd64"]
module.docker_pullpush.null_resource.docker_pullpush (local-exec): php7.4-apache: Pulling from library/wordpress
module.docker_pullpush.null_resource.docker_pullpush (local-exec): Digest: sha256:f9d68493ee98ea8f39e6e0fc2327b48e0b555ef0ec3fcc06b8d42cbc539c49a4
module.docker_pullpush.null_resource.docker_pullpush (local-exec): Status: Downloaded newer image for wordpress:php7.4-apache
module.docker_pullpush.null_resource.docker_pullpush (local-exec): docker.io/library/wordpress:php7.4-apache

module.docker_pullpush.null_resource.docker_pullpush (local-exec): The config profile (linux/amd64) could not be found

#!/bin/bash
if [[ ${#6} -gt 0 ]]; then
profile="--profile $6"
fi
if [[ ${#7} -gt 0 ]]; then
platform="--platform $7"
fi

It looks like $6 is the platform, not the profile.

@petewilcock
Copy link
Contributor Author

@blimmer Damn - am I right in saying you're not using a profile for your instantiation? I've just realised that if you don't, it'll shift the positional argument left and make $platform be at $6 instead of $7.

A silly assumption on my part, but I think I can refactor it out.

@blimmer
Copy link

blimmer commented May 15, 2022

Correct - I use aws-vault which sets AWS_* variables for a specific command or shell.

The benefit of this approach is that I get short-lived credentials without storing secrets in the ~/.aws/credentials file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying one (or multiple) platform targets Export the repository url from the module
2 participants