Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces Lambda@Edge with CloudFront Function #62

Merged
merged 9 commits into from
Apr 28, 2022
Merged

Replaces Lambda@Edge with CloudFront Function #62

merged 9 commits into from
Apr 28, 2022

Conversation

nvnivs
Copy link
Collaborator

@nvnivs nvnivs commented Apr 28, 2022

@nvnivs nvnivs mentioned this pull request Apr 28, 2022
Closed
petewilcock
petewilcock requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@petewilcock petewilcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really promising! Just one note. Look forward to try this against my personal project.

modules/cloudfront/main.tf Show resolved Hide resolved
@petewilcock petewilcock merged commit 35b37b1 into TechToSpeech:release/0.2.0 Apr 28, 2022
@petewilcock
Copy link
Contributor

Closes #57

@petewilcock
Copy link
Contributor

Great stuff @z0c thank you - this is a really helpful contribution, I'm quite excited for 0.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petewilcock petewilcock petewilcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nvnivs @petewilcock @krutisfood