Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Text): support setting heading level to span and header pretitleAs #1170

Merged
merged 3 commits into from
Jul 15, 2024
Merged

feat(Text): support setting heading level to span and header pretitleAs #1170

merged 3 commits into from
Jul 15, 2024

Conversation

Winde
Copy link
Contributor

@Winde Winde commented Jul 8, 2024 •
edited by atabel
Loading

(#1167)

Winde
Winde commented Jul 8, 2024
View reviewed changes
src/community/advanced-data-card.tsx
@@ -231,17 +231,15 @@ type AllowedExtra =
| typeof SimpleBlock
| typeof ValueBlock;

type TextAs = 'h1' | 'h2' | 'h3' | 'h4';
Copy link
Contributor Author

@Winde Winde Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restriction of up to H4 was incoherent with the rest of mistica.

It's already producing limitations on the project of configurability from CMS:
https://github.com/Telefonica/webapp/blob/775fe832e4707337d9478ff367a3981732678618/web/src/modular-pages/modules/components/data-card-advanced/index.tsx#L142

There does not seem to be a valid reason why a mistica Header can be up to H6 but the mistica community component is limited to H4

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Size stats

master this branch diff
Total JS 12 MB 12 MB +52 B
JS without icons 1.98 MB 1.98 MB +52 B
Lib overhead 61.1 kB 61.1 kB 0 B
Lib overhead (gzip) 16.3 kB 16.3 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@Winde Winde requested review from vdedios and yceballost July 8, 2024 10:31
@Winde
Copy link
Contributor Author

Winde commented Jul 8, 2024

On hold for https://jira.tid.es/browse/PRODUCTDSN-2500

We expect @MontseTelefonica to reach out to @yceballost to check what mistica documentation needs to be updated

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-let2oorfh-flows-projects-65bb050e.vercel.app

Built with commit 20ae04a.
This pull request is being automatically deployed with vercel-action

@Winde Winde force-pushed the carlos_support_span_in_heading_level_across_the_board_also_having_pretitle_as_heading/ACCOUNT-26117 branch from cf2ac32 to 339a911 Compare July 8, 2024 10:36
@yceballost
Copy link
Contributor

On hold for jira.tid.es/browse/PRODUCTDSN-2500

We expect @MontseTelefonica to reach out to @yceballost to check what mistica documentation needs to be updated

Yep, the specs should indicate that a title may not include hierarchy. The current specs are not updated with this definition.

@MontseTelefonica @aweell

@aweell aweell linked an issue Jul 12, 2024 that may be closed by this pull request
→ Accessibility: Components | Include span as a valid tag for cards title Telefonica/mistica-design#1827
Closed
3 tasks
@atabel atabel added this pull request to the merge queue Jul 15, 2024
@atabel atabel removed this pull request from the merge queue due to a manual request Jul 15, 2024
@atabel atabel changed the title feat(Text): support setting heading level to span and header pretitle… feat(Text): support setting heading level to span and header pretitleAs Jul 15, 2024
@atabel atabel added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 15, 2024
@atabel atabel enabled auto-merge July 15, 2024 10:50
@atabel atabel added this pull request to the merge queue Jul 15, 2024
Merged via the queue into master with commit 8abf43e Jul 15, 2024
11 checks passed
@atabel atabel deleted the carlos_support_span_in_heading_level_across_the_board_also_having_pretitle_as_heading/ACCOUNT-26117 branch July 15, 2024 11:10
tuentisre pushed a commit that referenced this pull request Jul 16, 2024
@semantic-release-bot
chore(release): 15.15.0 [skip ci]
447aeef 
# [15.15.0](v15.14.0...v15.15.0) (2024-07-16)

### Bug Fixes

* **overscroll color:** background color not changing when switching dark/light mode ([#1172](#1172)) ([9b74fe6](9b74fe6))

### Features

* **Cards:** add role prop for touchable cards ([#1169](#1169)) ([a2a7cbf](a2a7cbf))
* **css:** export mistica tokens as public css custom properties ([#1161](#1161)) ([c5f74bc](c5f74bc))
* **Header:** support headline (Tag) ([#1174](#1174)) ([07d8fae](07d8fae))
* **Text:** support setting heading level to span and header pretitleAs ([#1170](#1170)) ([8abf43e](8abf43e))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 15.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pladaria pladaria pladaria approved these changes

@atabel atabel atabel approved these changes

@wyunreal wyunreal wyunreal approved these changes

@penchochris penchochris penchochris approved these changes

@vdedios vdedios vdedios approved these changes

@yceballost yceballost Awaiting requested review from yceballost

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

→ Accessibility: Components | Include span as a valid tag for cards title
8 participants
@Winde @yceballost @tuentisre @pladaria @atabel @wyunreal @penchochris @vdedios