Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding basic auth for service endpoint #25

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Adding basic auth for service endpoint #25

merged 2 commits into from
Sep 2, 2019

Conversation

hkousha
Copy link
Contributor

@hkousha hkousha commented Aug 22, 2019

No description provided.

@hkousha
Copy link
Contributor Author

hkousha commented Aug 23, 2019

Let me know what you think about this, if okay I ll go ahead and update the README file.

@palmerabollo
Copy link
Member

Thanks for your contribution @hkousha. Please, go ahead and update the README file.

@hkousha
Copy link
Contributor Author

hkousha commented Aug 26, 2019

@palmerabollo updated the readme

palmerabollo
palmerabollo approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@palmerabollo palmerabollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution.

@palmerabollo
Copy link
Member

palmerabollo commented Aug 29, 2019 •
edited by jpfe-tid
Loading

@jpfe-tid LGTM, could you please review the gin part, too?

@palmerabollo palmerabollo merged commit fc9c1e5 into Telefonica:master Sep 2, 2019
@palmerabollo
Copy link
Member

New release 1.3.0 & docker image published.

@hkousha
Copy link
Contributor Author

hkousha commented Sep 3, 2019

Thanks guys,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpfe-tid jpfe-tid jpfe-tid approved these changes

@palmerabollo palmerabollo palmerabollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkousha @palmerabollo @jpfe-tid