Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove python 2.7 support #227

Merged
merged 3 commits into from
Mar 28, 2021
Merged

feat: remove python 2.7 support #227

merged 3 commits into from
Mar 28, 2021

Conversation

rgonalo
Copy link
Member

@rgonalo rgonalo commented Mar 19, 2021

No description provided.

@rgonalo rgonalo requested a review from a team March 19, 2021 08:09
@coveralls
Copy link

coveralls commented Mar 19, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 89.88% when pulling c41b4f5 on feat/remove_python2.7 into 7f5e862 on master.

@angel-ram
Copy link
Contributor

We are importing some libraries that are only used for python 2 in:

  • /toolium/utils/download_files.py
  • /toolium/test/utils/test_path_utils.py

@rgonalo
Copy link
Member Author

rgonalo commented Mar 19, 2021

I have removed more python 2 imports.
Thanks @angel-ram !

@rgonalo rgonalo merged commit 27cfc10 into master Mar 28, 2021
@rgonalo rgonalo deleted the feat/remove_python2.7 branch March 28, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgonalo @coveralls @angel-ram