This PR fixes #194 #195
Merged
This PR fixes #194 #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix infinite loop in get_dialogs() by preventing repeated dialogs - Added tracking of seen dialog IDs to avoid yielding duplicates - Added check for None top_message to safely stop pagination - Preserved support for limit, pinned_only, and chat_list parameters - Ensured correct offset updates for reliable pagination
fix: skip dialogs with no parsed chat to avoid errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the get_dialogs() method, where the function could enter an infinite loop or repeatedly yield the same dialogs, especially when certain Dialog entries were malformed or had missing data.