Skip to content

Publish SDK Version with each request #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Publish SDK Version with each request #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37493e9
Publish SDK Version with each request
winsmith Mar 21, 2022
754dcbc
Update tests to new format
winsmith Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/telemetrydeck.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export class TelemetryDeck {
appID: _app,
clientUser: _user,
sessionID: _user,
telemetryClientVersion: version,
type: type ?? 'pageview',
payload: transformPayload({
url,
Expand All @@ -84,6 +83,7 @@ export class TelemetryDeck {
platform: userAgentData ?? '',
vendor,
...payload,
telemetryClientVersion: `JavaScriptSDK ${version}`,
}),
},
]),
Expand Down
6 changes: 3 additions & 3 deletions tests/telemetrydeck.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ describe('TelemetryDeck.signal()', () => {
appID: 'foo',
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
telemetryClientVersion: version,
type: 'pageview',
payload: [
`url:${location.href}`,
`useragent:${navigator.userAgent}`,
`locale:${navigator.language}`,
`platform:${navigator.userAgentData ?? ''}`,
`vendor:${navigator.vendor}`,
`telemetryClientVersion:JavaScriptSDK ${version}`,
],
},
]),
Expand All @@ -84,14 +84,14 @@ describe('TelemetryDeck.signal()', () => {
appID: 'foo',
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
telemetryClientVersion: version,
type: 'pageview',
payload: [
`url:${location.href}`,
`useragent:${navigator.userAgent}`,
`locale:${navigator.language}`,
`platform:${navigator.userAgentData ?? ''}`,
`vendor:${navigator.vendor}`,
`telemetryClientVersion:JavaScriptSDK ${version}`,
],
},
]),
Expand All @@ -107,7 +107,6 @@ describe('TelemetryDeck.signal()', () => {
appID: 'foo',
clientUser: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
sessionID: 'fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9',
telemetryClientVersion: version,
type: 'pageview',
payload: [
`url:${location.href}`,
Expand All @@ -116,6 +115,7 @@ describe('TelemetryDeck.signal()', () => {
`platform:${navigator.userAgentData ?? ''}`,
`vendor:${navigator.vendor}`,
`baz:bat`,
`telemetryClientVersion:JavaScriptSDK ${version}`,
],
},
]),
Expand Down