Skip to content

Conversation

petarvujovic98
Copy link
Collaborator

@petarvujovic98 petarvujovic98 commented Mar 30, 2025

API Changes

Removes the list_borrows and list_supplys methods

@petarvujovic98 petarvujovic98 self-assigned this Mar 30, 2025
Copy link

Staging contract is deployed to gh-110.templar-in-training.testnet account


Gas Report

harvest_yield

Iterations Gas
0 3.0 Tgas
391 7.7 Tgas

Estimated snapshot limit: 23561

apply_interest

Iterations Gas
0 2.9 Tgas
391 16.4 Tgas

Estimated snapshot limit: 8168

@petarvujovic98
Copy link
Collaborator Author

@peer2f00l Do you want to have a service storing data to a DB for easier retrieval from the frontend? This would just be a convenience service, so doesn't affect the actual behavior?

@peer2f00l
Copy link
Collaborator

@petarvujovic98 We do not, and you are correct that this does not affect the integral behavior of the contract.

I think we can set up such a service, or use a preexisting indexer service. I have actually been discussing this performance improvement with @SmolinPavel , and had not yet decided on whether to pull the trigger. Regardless, even an indexer service is not necessarily required, since the account IDs can be scraped from the storage keys on the contract.

@peer2f00l peer2f00l merged commit 10d6914 into dev Mar 30, 2025
5 checks passed
@peer2f00l peer2f00l deleted the non-iterable-positions branch March 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use iterable collections to store borrow and supply positions

2 participants