Skip to content

Conversation

joshuajbouw
Copy link
Contributor

Its a bit excessive when we keep on needing to run the contract flows when working on code unrelated to the contract like the bots. I propose a change to improve this by adjusting the Github workflows relating to deployments to only run when any of those files had changed in the PR.

This fixes those issues by checking contract changes, or previous stages if they had run.

Related: #206

@joshuajbouw joshuajbouw requested a review from peer2f00l August 14, 2025 22:21
Copy link

github-actions bot commented Aug 14, 2025

Copy link
Collaborator

@peer2f00l peer2f00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise seems good!

@joshuajbouw
Copy link
Contributor Author

joshuajbouw commented Aug 15, 2025

@peer2f00l Added your request, makes sense. I also had removed Cargo.lock because Cargo.lock changes -could- happen on a NEAR smart contract which does change the gas costs and could cause tests to fail, and change gas costs. I should also remove Cargo.toml.

There is a caveat, that adding a dependency to say, bots would trigger a deployment but unsure how to get around that, unless the bots were in a different repo.

@peer2f00l peer2f00l merged commit a96e44d into dev Aug 18, 2025
6 checks passed
@peer2f00l peer2f00l deleted the 206-update-github-actions-with-check branch August 18, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants