Events & Linked Positions #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
peer2f00l
added
documentation
|
@SmolinPavel Let me know what additional events, or what additional details in the new events, should be included, if any. |
|
Staging contract is deployed to |
|
Staging contract is deployed to |
SmolinPavel
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked positions significantly improve the ergonomics and encapsulation of the borrow & supply positions. This (rather large) refactor was also necessary to cleanly implement event emission, so it is combined in this PR.
Breaking API change: This updates the
Accumulatorstruct (used for tracking interest/fees on borrow positions and yield on supply positions) to include apending_estimatefield, replacingpending_fee_estimateon borrow positions andpending_yield_estimateon supply positions. This field is NOT saved to contract storage.