Skip to content

Supply withdrawal fee #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 17, 2025
Merged

Supply withdrawal fee #46

merged 16 commits into from
Mar 17, 2025

Conversation

peer2f00l
Copy link
Collaborator

@peer2f00l peer2f00l commented Mar 13, 2025 •
edited
Loading

Depends on #16

@peer2f00l peer2f00l added the enhancement New feature or request label Mar 13, 2025
@peer2f00l peer2f00l self-assigned this Mar 13, 2025
@peer2f00l peer2f00l linked an issue Mar 13, 2025 that may be closed by this pull request
supply_withdrawal_fee #41
Closed
@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-46.templar-in-training.testnet account

@peer2f00l peer2f00l changed the base branch from dev to 16-event-emission March 13, 2025 06:59
@peer2f00l peer2f00l linked an issue Mar 13, 2025 that may be closed by this pull request
Enforce various configuration options #8
Closed
4 tasks
@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-46.templar-in-training.testnet account

Base automatically changed from 16-event-emission to dev March 13, 2025 14:28
@peer2f00l peer2f00l marked this pull request as ready for review March 13, 2025 14:48
@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-46.templar-in-training.testnet account

@peer2f00l peer2f00l enabled auto-merge (squash) March 13, 2025 16:55
royalf00l
royalf00l reviewed Mar 14, 2025
View reviewed changes
royalf00l
royalf00l reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@royalf00l royalf00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern is the u128 -> f64 conversion. Everything else lgtm

@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-46.templar-in-training.testnet account

@peer2f00l peer2f00l requested a review from royalf00l March 15, 2025 04:32
@peer2f00l peer2f00l removed the enhancement New feature or request label Mar 17, 2025
@peer2f00l peer2f00l merged commit 3e68d15 into dev Mar 17, 2025
4 checks passed
@peer2f00l peer2f00l deleted the 41-supply_withdrawal_fee branch March 17, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@royalf00l royalf00l royalf00l approved these changes

@SmolinPavel SmolinPavel Awaiting requested review from SmolinPavel

@petarvujovic98 petarvujovic98 Awaiting requested review from petarvujovic98

Assignees

@peer2f00l peer2f00l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

supply_withdrawal_fee Enforce various configuration options

2 participants

@peer2f00l @royalf00l