Skip to content

Remove panic during loss liquidation, use Deref and explicit &mut Market in Linked types #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Remove panic during loss liquidation, use Deref and explicit &mut Market in Linked types #86

merged 1 commit into from
Mar 25, 2025

Conversation

peer2f00l
Copy link
Collaborator

Additionally, some ergonomics improvements for linked positions.

@peer2f00l peer2f00l linked an issue Mar 25, 2025 that may be closed by this pull request
Handle taking a loss on liquidation #85
Closed
@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-86.templar-in-training.testnet account

Gas Report

harvest_yield

Iterations Gas
0 3.2 Tgas
10 4.0 Tgas
20 4.6 Tgas

petarvujovic98
petarvujovic98 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@petarvujovic98 petarvujovic98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

P.S. Pedantic nits
While simple to review (and a nice improvement), the PR title should probably have more detail.
The description points out the other changes, but it would still be nicer to see the topics of the PR in the title.

@peer2f00l peer2f00l changed the title Remove panic during loss liquidation Remove panic during loss liquidation, use Deref and explicit &mut Market in Linked types Mar 25, 2025
@peer2f00l peer2f00l merged commit fbf284d into dev Mar 25, 2025
5 checks passed
@peer2f00l peer2f00l deleted the 85-emit-event-when-protocol-takes-a-loss-on-a-liquidation branch March 25, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petarvujovic98 petarvujovic98 petarvujovic98 approved these changes

@SmolinPavel SmolinPavel Awaiting requested review from SmolinPavel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle taking a loss on liquidation

2 participants

@peer2f00l @petarvujovic98