Skip to content

Validate amount when creating withdrawal request #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2025
Merged

Validate amount when creating withdrawal request #88

merged 3 commits into from
Mar 29, 2025

Conversation

peer2f00l
Copy link
Collaborator

@peer2f00l peer2f00l commented Mar 25, 2025 •
edited
Loading

  • Resolves old TODO about validating requested withdrawal amount
  • Adds tests for withdrawal queue actions
  • Fixes a div0 bug

@github-actions GitHub Actions
Copy link

Staging contract is deployed to gh-88.templar-in-training.testnet account

Gas Report

harvest_yield

Iterations Gas
0 3.2 Tgas
10 4.0 Tgas
20 4.6 Tgas

@peer2f00l peer2f00l linked an issue Mar 27, 2025 that may be closed by this pull request
Resolve all TODOs and clippy::pedantic lints #72
Closed
SmolinPavel
SmolinPavel approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@SmolinPavel SmolinPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love the tests 👍

@peer2f00l peer2f00l merged commit 22ddcc6 into dev Mar 29, 2025
5 checks passed
@peer2f00l peer2f00l deleted the chore/old-todos branch March 29, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmolinPavel SmolinPavel SmolinPavel approved these changes

@petarvujovic98 petarvujovic98 Awaiting requested review from petarvujovic98

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resolve all TODOs and clippy::pedantic lints

2 participants

@peer2f00l @SmolinPavel