Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeSelect] 有 valueDisplay 时，clearable 失效 #1743

Closed
moecasts opened this issue Nov 24, 2022 · 2 comments · Fixed by #1757
Closed

[TreeSelect] 有 valueDisplay 时，clearable 失效 #1743

moecasts opened this issue Nov 24, 2022 · 2 comments · Fixed by #1757

Comments

@moecasts
Copy link
Collaborator

moecasts commented Nov 24, 2022 •
edited
Loading

tdesign-react 版本

0.43.1

重现链接

https://codesandbox.io/s/tdesign-react-demo-forked-us3dmp?file=/src/demo.jsx

重现步骤

如题，同时设置 valueDisplay 和 clearable 时，无法展示清除按钮。

期望结果

可以正常展示清除按钮

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

SelectInput 组件单选模式的问题。

https://github.com/Tencent/tdesign-react/blob/develop/src/select-input/useSingle.tsx#L72
@github-actions
Copy link
Contributor

👋 @moecasts，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022 •
edited
Loading

♥️ 有劳 @HQ-Lin @Hoofoo-WHU 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @moecasts 。

honkinglin added a commit that referenced this issue Nov 28, 2022
@honkinglin
fix(tree-select): 修复 valueDisplay 清空按钮不展示问题
d764620 
fix #1743
@honkinglin honkinglin mentioned this issue Nov 28, 2022
Merged
16 tasks
uyarn added a commit that referenced this issue Nov 30, 2022
@honkinglin @uyarn
fix(tree-select): 修复 valueDisplay 清空按钮不展示问题 (#1757)
339bac7 
* fix(tree-select): 修复 valueDisplay 清空按钮不展示问题

fix #1743

* chore: update select demo

Co-authored-by: Uyarn <uyarnchen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tree-select): 修复 valueDisplay 清空按钮不展示问题 Tencent/tdesign-react
1 participant
@moecasts