Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): 修复滚动失效问题 #1021

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Jul 1, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Dialog): 修复滚动失效问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin honkinglin changed the title Fix/dialog/scroll fix(Dialog): 修复滚动失效问题 Jul 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (7b04365) to head (e4b1595).
Report is 1559 commits behind head on develop.

Files with missing lines Patch % Lines
src/dialog/RenderDialog.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1021      +/-   ##
===========================================
- Coverage    60.40%   60.34%   -0.07%     
===========================================
  Files          937      951      +14     
  Lines        16498    16624     +126     
  Branches      3743     3791      +48     
===========================================
+ Hits          9966    10032      +66     
- Misses        6532     6592      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

完成

@honkinglin honkinglin force-pushed the fix/dialog/scroll branch from 0ab6828 to e4b1595 Compare July 4, 2022 02:39
@honkinglin honkinglin merged commit 9591fd5 into develop Jul 4, 2022
@honkinglin honkinglin deleted the fix/dialog/scroll branch July 4, 2022 02:46
This was referenced Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants