Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): breakline #1032

Merged
merged 6 commits into from
Jul 4, 2022
Merged

fix(Select): breakline #1032

merged 6 commits into from
Jul 4, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jul 4, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

修复Select换行过早的问题

Select此前即使改成breakline multiple下换行的表现还是和原有的select表现有不同
表现为在

  1. 没有开启过滤时仍然占行
  2. 有足够空间的时候仍然提前换行占满一行

对于问题1 增加非对外暴露API showInput 由tagInput透传
对于问题2 增加非对外暴露API keepWrapperWidth 因为需要同时利用autoWidth 让input标签宽度自适应 又需要保留select/tag-input默认的宽度

修复前后对比

before.mp4
Jun-28-2022.11-08-39.mp4

更新Select的demo示例内容

📝 更新日志

  • fix(select): 修复多选下换行提前占满一行的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn changed the title fix select breakline fix(Select): breakline Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

完成

@uyarn uyarn force-pushed the fix/select-breakline branch from a8bb585 to a3b77af Compare July 4, 2022 01:33
@codecov-commenter
Copy link

Codecov Report

Merging #1032 (a3b77af) into develop (7b04365) will increase coverage by 0.04%.
The diff coverage is 55.63%.

@@             Coverage Diff             @@
##           develop    #1032      +/-   ##
===========================================
+ Coverage    60.40%   60.44%   +0.04%     
===========================================
  Files          937      951      +14     
  Lines        16498    16690     +192     
  Branches      3743     3794      +51     
===========================================
+ Hits          9966    10089     +123     
- Misses        6532     6601      +69     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1e652...a3b77af. Read the comment docs.

@uyarn uyarn force-pushed the fix/select-breakline branch from a3b77af to a5cdb80 Compare July 4, 2022 02:47
@uyarn uyarn force-pushed the fix/select-breakline branch from ba6b304 to 55be2ac Compare July 4, 2022 03:02
@honkinglin honkinglin merged commit 6c3ea20 into develop Jul 4, 2022
@honkinglin honkinglin deleted the fix/select-breakline branch July 4, 2022 03:12
This was referenced Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants