-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Select): breakline #1032
Merged
Merged
fix(Select): breakline #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
force-pushed
the
fix/select-breakline
branch
from
July 4, 2022 01:33
a8bb585
to
a3b77af
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1032 +/- ##
===========================================
+ Coverage 60.40% 60.44% +0.04%
===========================================
Files 937 951 +14
Lines 16498 16690 +192
Branches 3743 3794 +51
===========================================
+ Hits 9966 10089 +123
- Misses 6532 6601 +69
Continue to review full report at Codecov.
|
uyarn
force-pushed
the
fix/select-breakline
branch
from
July 4, 2022 02:47
a3b77af
to
a5cdb80
Compare
honkinglin
approved these changes
Jul 4, 2022
uyarn
force-pushed
the
fix/select-breakline
branch
from
July 4, 2022 03:02
ba6b304
to
55be2ac
Compare
This was referenced Jul 4, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
修复Select换行过早的问题
Select此前即使改成breakline multiple下换行的表现还是和原有的select表现有不同
表现为在
对于问题1 增加非对外暴露API
showInput
由tagInput透传对于问题2 增加非对外暴露API
keepWrapperWidth
因为需要同时利用autoWidth 让input标签宽度自适应 又需要保留select/tag-input默认的宽度修复前后对比
before.mp4
Jun-28-2022.11-08-39.mp4
更新Select的demo示例内容
📝 更新日志
fix(select): 修复多选下换行提前占满一行的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单